nmap in a shell script : some issues

Question

I decided to make a shell script for basic nmap scanning so I did it like this :

#!/bin/bash

sudo apt-get install nmap 

printf "enter the name of site to do basic scan on >>>"

read NAME

nmap $NAME

echo "Do you wish to do Software Version scan?"
select yn in "Yes" "No"; do
    case $yn in
        Yes ) goto 17; break;;
        No ) exit;;

nmap $NAME -sV

echo "Do you wish to do OS scan?"
select yn in "Yes" "No"; do
    case $yn in
        Yes ) goto 25; break;;
        No ) exit;;

nmap $NAME -O

But the output was :

Nmap done: 1 IP address (1 host up) scanned in 109.97 seconds
Do you wish to do Software Version scan?
./nmap-basic.sh: line 17: syntax error near unexpected token `$NAME'
./nmap-basic.sh: line 17: `nmap $NAME -sV'

Any solutions?

Answer 1

case in bash should end in esac, select should end in done. I don't see those keywords in your script.

select NAME [in WORDS ... ;] do COMMANDS; done
case WORD in [PATTERN [| PATTERN]...) COMMANDS ;;]... esac

Answer 2

your shell script has a alot problem, i rewrite that for you.

#!/bin/bash
echo -en "Enter name of website ?"
read name
echo -e "\e[93mScanning...\e[0m"
nmap $name
# software Scan
echo "############################################"
echo "Do you wish to do Software Version scan?"
read ans
    if [ "$ans" = "yes" ] || [ "$ans" = "YES" ]
     then   
    echo "############################################"
    echo -e "\e[91m Software Scanning...\e[0m" 
    nmap -sV $name
    fi
## OS Scan
echo "Do you wish to do OS scan?"
read ans
    if [ "$ans" = "yes" ] || [ "$ans" = "YES" ]
      then
    echo -e "\e[92m OS Scanning...\e[0m" 
    sudo nmap -O $name
     fi 
exit 0

in fact you don't need select command because in "no" case you don't have any work to do , and you can use break|continue in loop not in case statement. i added some color to make it beauty. have fun bro