linux bash script to create folder and move files [duplicate]

Question

Hello I need to create folder based on a filename and in this folder create another one and then move file to this second folder

example:

cat.jpg
create folder cat
create folder picture
move cat.jpg to picture 

all my .jpg files are in

/root/Desktop/My_pictures

so it should look like this:

example picture "cat.jpg"

/root/Desktop/My_pictures/cat/pictures/cat.jpg

Sorry if I'm not precise but English is not my native language.

Best Regards and Thank You

Answer 1

You can also remove the ls *.jpg and simply use shell globbing:

#!/bin/bash

for full_filename in *jpg; do
  extension="${full_filename##*.}"
  filename="${full_filename%.*}"
  mkdir -p "$filename/picture"
  mv "$full_filename" "$filename/picture"
done

Please create and run this script inside /root/Desktop/My_pictures.

Answer 2

A similar approach:

#!/usr/bin/env bash

## iterate through each file whose name ends in 'jpg'
## saving it as $file. ~ is your $HOME directory
for file in ~/Desktop/My_pictures/*jpg
do
    ## basename will remove the path (~/Desktop/My_pictures) and also
    ## remove the extension you give as a second argument    
    name="$(basename "$file" .jpg)"

    ## create the directory, the -p means it will create 
    ## the parent directories if needed and it won't complain
    ## if the directory exists.
    mkdir -p ~/Desktop/My_pictures/"$name"

    ## copy the file to the new directory
    mv "$file" "~/Desktop/My_pictures/$name"
done

Save the script above as, for example, ~/movefiles.sh, make it executable with chmod +x movefiles.sh and run it:

~/movefiles.sh