Take the 2-minute tour ×
Ask Ubuntu is a question and answer site for Ubuntu users and developers. It's 100% free, no registration required.

I have a branch to be merged here:

https://code.launchpad.net/~headbangerkenny/ubuntuone-android-music/branch/+merge/71364

I got told what I needed to fix and did that, do I need to set anything else?

I can't find any kind of help on help.launchpad.net so I'm stuck

(It's probably something really really silly, but ya know!)

share|improve this question
add comment

2 Answers 2

up vote 3 down vote accepted

Looking at your merge request, you need to leave a comment saying "I did what you asked, it's ready now". Then the person at the other end who is the maintainer (or is otherwise in charge of merge requests) will take a look and say "Yes, this is what we asked you to fix" or "Hey, can you go fix this differently?" etc, then they'll merge it in once they're satisfied that it's in good working order.

share|improve this answer
add comment

Adding a comment saying that you've fixed the issue is usually enough. Especially with a new contributor, the reviewer is probably keeping an eye on the merge proposal. Though, you can manually push the merge proposal back into the review queue by changing its status. Different projects have their own internal work-flows.

"Needs fixing" is the result of the review. "Work in-progress" is the status of the merge request.

Near the top of the page, you should see:

status: work in-progress

Click on the yellow edit icon, and change the status back to "Needs review."

needs review

share|improve this answer
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.